From 9fb887da0bf858f09b01d0199fd1aeac5242537b Mon Sep 17 00:00:00 2001 From: GPSBabel <12013583+GPSBabelDeveloper@users.noreply.github.com> Date: Wed, 15 Dec 2021 23:48:03 -0500 Subject: [PATCH] Possible unterminated string in humminbird (#794) Leave space for null terminator when copying string into fixed-size buffer. --- humminbird.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/humminbird.cc b/humminbird.cc index 40765ec48..ac628b9a3 100644 --- a/humminbird.cc +++ b/humminbird.cc @@ -875,7 +875,7 @@ humminbird_rte_tail(const route_head* rte) be_write32(&humrte->time, humrte->time); QString name = mkshort(rtename_sh, rte->rte_name); - strncpy(humrte->name, CSTR(name), sizeof(humrte->name)); + strncpy(humrte->name, CSTR(name), sizeof(humrte->name)-1); gbfputuint32(RTE_MAGIC, fout_); gbfwrite(humrte, sizeof(*humrte), 1, fout_); -- 2.30.2